feat: support start time parameter on read changes #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minder Vulnerability Report ✅Minder analyzed this PR and found it does not add any new vulnerable dependencies.
|
feat: support start time parameter on read changes
ryanpq
force-pushed
the
feat-support-start-time-parameter-on-read-changes
branch
from
20718e8 to
a1f7cbb
Compare
ewanharris
reviewed
Jan 31, 2025
| if startTime != "" { | ||
| layout := "2006-01-02T15:04:05Z" | ||
|
|
||
| parsedTime, err := time.Parse(layout, startTime) |
There was a problem hiding this comment.
Should we be using time.RFC3339 here as that's what we use in the go-sdk, or is the 2006-01-02T15:04:05Z07:00 format a little bit too lengthy to write out on the CLI?
There was a problem hiding this comment.
The API docs call for ISO8601 which in go requires a layout variable as it differs slightly from RFC3339. The go-sdk expects input to be a time.Time object but since we're taking text input in the CLI this ensures that ISO8601 is properly supported as detailed in the API documentation.
There was a problem hiding this comment.
Ahh my bad, I overlooked we were just using that in the tests
Co-authored-by: Ewan Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for start_time parameter in read changes
References
openfga/go-sdk#158
Review Checklist
main